search

react-native-elements / playground

Exploring Possibilities with React Native Elements
https://react-native-elements.js.org
MIT License
19 stars 43 forks source link

bug: Apparently a typo in .gitignore #29

Closed iamsaumya closed 3 years ago

iamsaumya commented 3 years ago

This line seems to be a typo, I am aware of the package-lock.json but not the package-json.lock file.

https://github.com/react-native-elements/playground/blob/562107d49b6fb7e6f558396c1ca1abe3c400b39d/.gitignore#L21

Is it a specific file that npm creates? There is a possibility I don't know about it.

iamsaumya commented 3 years ago

Adding to that, I don't see package-lock.json in the codebase I believe it should be added to a git repo.

tewarig commented 3 years ago

well, @iamsaumya I don't think that is a typo.😅 check this.. https://github.com/nodejs/citgm/issues/451

iamsaumya commented 3 years ago

I see, in that case. The typo package-json.lock should be package-lock.json, Isn't it?

iamsaumya commented 3 years ago

I think it will better to inform the author of https://github.com/react-native-elements/playground/pull/23 to fix the typo in .gitignore as he is pushing the lock file to repo.

pranshuchittora commented 3 years ago

We need a lock file either from npm or yarn. I personally use yarn, but let's keep npm lock files as we are using npm in the build pipeline