fix: Drawer navigation bug complete fix made

react-native-elements / playground

Exploring Possibilities with React Native Elements

https://react-native-elements.js.org

MIT License

19 stars 43 forks source link

fix: Drawer navigation bug complete fix made #30

Closed Uyadav207 closed 3 years ago

Uyadav207 commented 3 years ago

@pranshuchittora, the issue #20 , wasn't completely fixed by the PR #21 .

Issues still occuring

on clicking the links, the drawer was navigating to the link, but not closing after navigating.

I have fixed the bug completely, Kindly check.

screen gif after fix

captured

[x] checked the bug on ios and android as well

netlify[bot] commented 3 years ago

Deploy preview for rne-playground ready!

Built with commit 90ffadebc3352df906462ecc6d873320c14ecf4b

https://deploy-preview-30--rne-playground.netlify.app

ankushdutt commented 3 years ago

This change will break the desktop version, though. There is undesirable toggling of nav drawer whenever clicked on drawer links/items as shown in this gif: drawer

Uyadav207 commented 3 years ago

This change will break the desktop version. There is undesirable toggling of nav drawer whenever clicked on drawer links/items.

Thanks for your concern

but I have rechecked the changes, they are working well in desktop(browsers) as well as smart phones.

There was a need of onClick handler that on clicking will redirect the user to particular components page. Also Toggle Back the Drawer Navigation to its previous state

@pranshuchittora please review the PR, and confirm that the bug is completely fixed or not.

Thanks.

Uyadav207 commented 3 years ago

Thanks @ankushdutt, :)

Previous issue

After resolving (DESKTOP)

captured (1)

After resolving (SMART PHONES)

smart

pranshuchittora commented 3 years ago

LGTM :+1: Thanks @Uyadav207

Uyadav207 commented 3 years ago

Happy to contribute @pranshuchittora. :)