search

react-native-elements / playground

Exploring Possibilities with React Native Elements
https://react-native-elements.js.org
MIT License
19 stars 43 forks source link

code fixes 1 #31

Closed Devesh21700Kumar closed 3 years ago

Devesh21700Kumar commented 3 years ago

1).restructured props in pages/home 2).relative imports from directories external to /src are not allowed in modern react versions so fixed them to adapt with latest versions 3).made Avatar a functional component

for issue #3

netlify[bot] commented 3 years ago

Deploy preview for rne-playground ready!

Built with commit 75261b8d490610a696ae49ee0751eb0d51a8b9b6

https://deploy-preview-31--rne-playground.netlify.app

Devesh21700Kumar commented 3 years ago

well done... please mention the issue as well this pr is solving. I think it is #3

thanks.. yeah i have mentioned it now @pranshuchittora could u pls merge this too?

pranshuchittora commented 3 years ago

Deploy preview for rne-playground ready!

Built with commit b16bc2d

https://deploy-preview-31--rne-playground.netlify.app

@Devesh21700Kumar pls check the build from your changes.

  1. Go to any component
  2. Click the Prop Explorer at the bottom right
  3. Check the console for the respective err
Devesh21700Kumar commented 3 years ago

@pranshuchittora Hey, Thanks for the review.. I've fixed the Build errors and have made the export named instead of default.. please do check and merge if it is not giving any errors

Devesh21700Kumar commented 3 years ago

@pranshuchittora I have reverted them now. Please check and merge. Thanks

pranshuchittora commented 3 years ago

Pls resolve the conflicts