search

react-native-elements / playground

Exploring Possibilities with React Native Elements
https://react-native-elements.js.org
MIT License
19 stars 43 forks source link

UI improvement on Home Page #40

Closed shivambalwani closed 2 years ago

shivambalwani commented 3 years ago

issue #3 : Added a typing effect on "Exploring possibilities" . @pranshuchittora is it good or i need to add some changes to it?

netlify[bot] commented 3 years ago

Deploy preview for rne-playground processing.

Building with commit fe005f8cb1e01fb0ab68f198859e64c1a8a368ea

https://app.netlify.com/sites/rne-playground/deploys/6055a5b5c5274e00071023c5

Uyadav207 commented 3 years ago

@shivambalwani , Great

shivambalwani commented 3 years ago

@shivambalwani,

Problems

  • Direct CSS used.
  • Package-lock.json conflict

Solution

  • try making CSS modules
  • Delete package-lock.json and commit changes on your PR branch

I have added CSS modules & removed package-lock.json. Thanks!

shivambalwani commented 3 years ago

well, we can also directly add the typewriting effect. instead of using another package. using {useEfect, useState} hooks. check out this code snippet. https://gist.githubusercontent.com/abecus/7d20f05a140e99088d9f37517bd594c3/raw/28e0a625691ee655d097fb68cff09f1dd9168ae1/typewriter.js

yes, we can but using this package provides more effects which can be applied quite easily when the user needs.

pranshuchittora commented 3 years ago

Typing effect is not required & styles are breaking on the home page (spacing issue)

shivambalwani commented 3 years ago

Typing effect is not required & styles are breaking on the home page (spacing issue)

Ok, I will remove the typing effect .But i am not able to understand where the styles are breaking 🤔

pranshuchittora commented 3 years ago

https://deploy-preview-40--rne-playground.netlify.app/#/ Check the section below Explore Now button, compare the same with this -> https://deploy-preview-40--rne-playground.netlify.app/#/

shivambalwani commented 3 years ago

@pranshuchittora fixed the style breaking issue and removed the typing effect.plz check.

shivambalwani commented 3 years ago

Left some comments.

@pranshuchittora i have fixed the style naming, but the checks are failing. I don't know why?

pranshuchittora commented 3 years ago

Pls pull the new changes and resolve the conflicts.