react-native-elements / playground

Exploring Possibilities with React Native Elements
https://react-native-elements.js.org
MIT License
19 stars 43 forks source link

Chore(warnings): Rectification of code by removing all (jsx-A11y) warnings (closed due to Conflict) #45

Closed Uyadav207 closed 3 years ago

Uyadav207 commented 3 years ago

Warnings earlier

netlify[bot] commented 3 years ago

Deploy preview for rne-playground ready!

Built with commit cd28e20a0d95f522aee396beb6d461490a8d4359

https://deploy-preview-45--rne-playground.netlify.app

Uyadav207 commented 3 years ago

No @tewarig I have made new branch for this commit .... they are the previous ones... 😅

Thanks for your concern✌️

Uyadav207 commented 3 years ago

And it do not comes under #3 because i haven't done any...

Just removed ⚠️ warnings

tewarig commented 3 years ago

And it do not comes under #3 because i haven't done any...

  • Folder restructuring
  • Styling

Just removed warnings

still, you are improving the quality of code... 😅

pranshuchittora commented 3 years ago

Resolve the conflicts & clicking on the Playground in the drawer in the mobile more should close the drawer, can you fix that as well ?

Screenshot from 2021-03-12 20-27-21

Uyadav207 commented 3 years ago

@pranshuchittora ok I will try to fix it.

Uyadav207 commented 3 years ago

@pranshuchittora, I got the reason for this conflict... The PR #22 is merged ... before i.e why this pr is causing merge conflict.

I will be making changes sooner with the drawer fix.

Uyadav207 commented 3 years ago

@pranshuchittora, I might need to reopen this. Please Try to merge it ASAP

Reason for conflicts

Solution

Uyadav207 commented 3 years ago

i have made another PR, #47 ... please close this.