search

react-native-elements / playground

Exploring Possibilities with React Native Elements
https://react-native-elements.js.org
MIT License
19 stars 43 forks source link

fix loading style in socialicon #52

Closed ankushdutt closed 2 years ago

ankushdutt commented 3 years ago

fixes #51

image

netlify[bot] commented 3 years ago

Deploy preview for rne-playground ready!

Built with commit c5a3207dc322f2e3dbd44c9dc4fbe1ef94c935cd

https://deploy-preview-52--rne-playground.netlify.app

ankushdutt commented 3 years ago

fixed the loading issue here (https://github.com/react-native-elements/react-native-elements/pull/2846) Added the activityIndicatorStyle for socialicons to the playground here, so we can merge this one too @pranshuchittora

pranshuchittora commented 3 years ago

@ankushdutt thanks for finding the issue and fixing the same in the core. Is activityIndicatorStyle is a new prop ?

If yes, then pls add the same to the docs (https://github.com/react-native-elements/react-native-elements/tree/next/website/docs/props) so that it can be automatically pulled in the Playground via #15

ankushdutt commented 3 years ago

Is activityIndicatorStyle is a new prop ?

No, it was already present in the codebase of React Native Elements Core (I haven't added them in my fix there). Though, its not present in SocialIcon docs

Alright, I'll make a PR for the missing props in the core.

pranshuchittora commented 3 years ago

Did you made a PR for the activityIndicatorStyle

ankushdutt commented 3 years ago

Did you made a PR for the activityIndicatorStyle

Yes, here: https://github.com/react-native-elements/react-native-elements/pull/2946