search

react-native-elements / playground

Exploring Possibilities with React Native Elements
https://react-native-elements.js.org
MIT License
19 stars 43 forks source link

Add .prettierrc file fixes #56 #57

Closed jugshaurya closed 3 years ago

jugshaurya commented 3 years ago

fixes #56

netlify[bot] commented 3 years ago

Deploy preview for rne-playground ready!

Built with commit b77c2b8e1a0cf78f9617ee1a23aa01b704d35ff9

https://deploy-preview-57--rne-playground.netlify.app

pranshuchittora commented 3 years ago

Can you setup Husky with Prettier in this PR? Later you can do ESLint (later because we need to fix the guidelines before that via an RFC)

jugshaurya commented 3 years ago

Can you setup Husky with Prettier in this PR? Later you can do ESLint (later because we need to fix the guidelines before that via an RFC)

Yes sure @pranshuchittora, actually was working on it. Will add husky with prettier

And will add eslint to the project as well. You can mark me assignee for this. Will make a pr today

jugshaurya commented 3 years ago

Added Husky and prettier for consistent styling across the codebase.

  • Imp: already ran prettier over all the files in the src directory via npm run format.
  • added format script for future reference
  • now complete codebase is consistent with styling via prettier.
  • and bad commits protected via husky.

fixes #56 @pranshuchittora please review

jugshaurya commented 3 years ago

Also I want to work on adding eslint to project. Let me know when guideline rfc is updated. Will create a issue and pr for same as soon as you update me. Thanks.

pranshuchittora commented 3 years ago

LGTM :) Thanks