react-native-elements / playground

Exploring Possibilities with React Native Elements
https://react-native-elements.js.org
MIT License
19 stars 43 forks source link

Added external styling for propdrawer & playground #60

Closed shivambalwani closed 2 years ago

shivambalwani commented 3 years ago

issue #3 : Added External Styling for the Components Propdrawer and Playground.

netlify[bot] commented 3 years ago

Deploy preview for rne-playground processing.

Building with commit 1cec0892316aa10d3a1dc9cf6eb2c286947effe5

https://app.netlify.com/sites/rne-playground/deploys/6055aa244bfa7600080084e1

Uyadav207 commented 3 years ago

I think if you are changing UI, please make a discussion for that particular UI issue. Possible Solution

I hope it makes any sense. Thanks.

tewarig commented 3 years ago

I think if you are changing UI, please make a discussion for that particular UI issue. Possible Solution

  • prepare mockups.
  • discuss with maintainer @pranshuchittora.
  • Then Make PR

I hope it makes any sense. Thanks.

@shivambalwani I tried to see what is causing this UI to break. have a look at the elements.style in this pr Screenshot from 2021-03-13 23-04-33 elements.style in the main deployment. Screenshot from 2021-03-13 23-00-09 just figure out a way to add these styles. hope it helps.

shivambalwani commented 3 years ago

I think if you are changing UI, please make a discussion for that particular UI issue. Possible Solution

  • prepare mockups.
  • discuss with maintainer @pranshuchittora.
  • Then Make PR

I hope it makes any sense. Thanks.

@shivambalwani I tried to see what is causing this UI to break. have a look at the elements.style in this pr Screenshot from 2021-03-13 23-04-33 elements.style in the main deployment. Screenshot from 2021-03-13 23-00-09 just figure out a way to add these styles. hope it helps.

thanks!

shivambalwani commented 3 years ago

Left some comments

@pranshuchittora i have fixed the style naming, but the checks are failing. I don't know why?

pranshuchittora commented 3 years ago

Oops! Pls pull the new changes & resolve the conflicts.

shivambalwani commented 3 years ago

Oops! Pls pull the new changes & resolve the conflicts.

pulled the new changes still unable to resolve.Still Trying