CheckBox Enhancements: fix checkbox not checking, right not working, leftIcon, add description for all props

react-native-elements / playground

Exploring Possibilities with React Native Elements

https://react-native-elements.js.org

MIT License

19 stars 43 forks source link

CheckBox Enhancements: fix checkbox not checking, right not working, leftIcon, add description for all props #65

Closed ankushdutt closed 3 years ago

ankushdutt commented 3 years ago

fixes: #64

Update code to enable checkbox check on clicking
increased width of container so that checking of right and center props have visible changes
Added descriptions for all props
Removed leftIcon prop (not supported by CheckBox component)

Recording after fixes: https://www.loom.com/share/514d5d70dec54c2fb8bf4ac16a64399f

Edited: New recording: https://www.loom.com/share/e8540f356ab74f159105143643fb4856

netlify[bot] commented 3 years ago

Deploy preview for rne-playground ready!

Built with commit 1bb439f25710b8ee3bf7fd4c52fa62cca4ad44be

https://deploy-preview-65--rne-playground.netlify.app

ankushdutt commented 3 years ago

Removed center and right props. See discussion here: https://github.com/react-native-elements/react-native-elements/pull/2849

ankushdutt commented 3 years ago

There was no problem with the props, and it seems to be working fine when the container width is large enough. I have added them back and increased the width of the container. We can now merge this one @pranshuchittora.

pranshuchittora commented 3 years ago

Pls resolve the conflicts.

piyushdevOP commented 3 years ago

@ankushdutt Hey buddy the fix looks working. What are the conflicts arising?

pranshuchittora commented 3 years ago

LGTM :)

pranshuchittora commented 3 years ago

Thanks