🔥( Hot-Fix ): fixes UI breaking by error rendering component of (react-view) in playground area.

react-native-elements / playground

Exploring Possibilities with React Native Elements

https://react-native-elements.js.org

MIT License

19 stars 43 forks source link

🔥( Hot-Fix ): fixes UI breaking by error rendering component of (react-view) in playground area. #76

Closed Uyadav207 closed 3 years ago

Uyadav207 commented 3 years ago

What kind of change does this PR introduce?

🔥( Hot-Fix ): fixes UI breaking by error rendering component of (react-view) in the playground area.

Did you add tests for your changes?

Not required(tested manually)

If relevant, did you update the documentation?

Not required

Summary

The error component should not break the UI.
This will cause the user un-comfortable while using the playground web app.
Fixes #75

Does this PR introduce a breaking change?

No breaking changes are involved.

Other information (screenshot after the fix)

Screenshot from 2021-03-16 12-43-31

netlify[bot] commented 3 years ago

Deploy preview for rne-playground ready!

Built with commit 93e9b8b92240e9140e5f7121ead4202cf7a3417e

https://deploy-preview-76--rne-playground.netlify.app

Uyadav207 commented 3 years ago

@flyingcircle and @pranshuchittora done with the fix... Kindly review it...

pranshuchittora commented 3 years ago

Too many files 😕 The branch of this PR seems to be forked from the previous PR.

Uyadav207 commented 3 years ago

I have made a new branch pushed the changes.... Didn't fork the previous branch @pranshuchittora

Uyadav207 commented 3 years ago

I think upper commits are related to the previous commit logg .... nothings to do with this PR.. i have checked that i have forked master branch and did changes ....

Please have a look

pranshuchittora commented 3 years ago

Can you pull the latest changes from the master

Uyadav207 commented 3 years ago

I will do it and have to make a new pr... please try to merge it sir... before any further conflict.. :)

Uyadav207 commented 3 years ago

@pranshuchittora, after merging #15...

getting this error.

Screenshot from 2021-03-20 08-57-28

It says no directory props found...
So to resolve this issue.... I might want to create a props folder and put all the MDX files.... that I have created in #53...
Then this will work fine ... may I go with this .

Uyadav207 commented 3 years ago

@pranshuchittora, sir... in #15... the changes made in ... Content folder in .jsx files


import PropDrawer from "../../components/PropDrawer";
import Playground from "./searchbar.playground.jsx";

const Content = lazy(() => importMDX("../Props/searchbar.md"));

export default function SearchBarPlayground() {
  return (
    <div>
      <Playground />
      <Suspense fallback={<div>Loading...</div>}>
        <PropDrawer>
          <Content />
        </PropDrawer>
      </Suspense>
    </div>
  );
}

Are these chunks of code are repeated allover... and this is making a problem in compiling the web app...

And also please let me know the file type of markdown.... is it MD or mdx

Uyadav207 commented 3 years ago

Made a New PR.. Resolving the merge conflict... @pranshuchittora ... #87