search

react-native-elements / playground

Exploring Possibilities with React Native Elements
https://react-native-elements.js.org
MIT License
19 stars 43 forks source link

Added clear functionality to icon in the Input component #79

Open mhmd21 opened 3 years ago

mhmd21 commented 3 years ago

What kind of change does this PR introduce? I have added clearing functionality to the close icon inside of the input component.

Did you add tests for your changes? It is not needed.

If relevant, did you update the documentation? It is irrelevant.

Summary Attached Ref to the Input component and accessed it inside the icon's onPress function. Issue #70.

Does this PR introduce a breaking change? No it doesn't introduce any breaking changes.

netlify[bot] commented 3 years ago

Deploy preview for rne-playground ready!

Built with commit 5639802eff767ed08959e17e10fb0b2899321f19

https://deploy-preview-79--rne-playground.netlify.app

mhmd21 commented 3 years ago

This works but seems not the right approach. Can you fix this using the state hook https://react-view.netlify.app/?path=/story/useview--state-hook

I have changed the implementation to use the state hook instead.

pranshuchittora commented 3 years ago

CI is failing, can you pls pull the new changes from the master.

pranshuchittora commented 3 years ago

LGTM

pranshuchittora commented 3 years ago

Thanks