search

react-native-elements / playground

Exploring Possibilities with React Native Elements
https://react-native-elements.js.org
MIT License
19 stars 43 forks source link

Hot fix: resolved merge conflicts, updated UI breaking and updated props docs(rectified redundant code). #87

Closed Uyadav207 closed 3 years ago

Uyadav207 commented 3 years ago

What kind of change does this PR introduce?

Did you add tests for your changes?

Summary

ERROR RESOLVED IS SHOWN BELOW

Does this PR introduce a breaking change?

Other information

before

After (Fixes #75 )

netlify[bot] commented 3 years ago

Deploy preview for rne-playground ready!

Built with commit 84d8e0499ae78d7d02580a3e6fec17e1c04dab11

https://deploy-preview-87--rne-playground.netlify.app

Uyadav207 commented 3 years ago

@pranshuchittora, The checks are failing because....

when tried to update the Props folder... it is not pushing....then after looking at this issue... I found that you have pushed the Props folder in .gitignore, That is why ... the checks are not passing as there is no prop folder found.

DO we really need to push the props folder

pranshuchittora commented 3 years ago

@Uyadav207 this is not required as #15 introduces remote docs for always up-to-dated docs.

Uyadav207 commented 3 years ago

ok Got it... @pranshuchittora ... Also The UI for error render is quite buggy may, I give the PR for that instead.

Uyadav207 commented 3 years ago

As that changes were included ... in this PR also but no worries

pranshuchittora commented 3 years ago

Sure, Feel free to open a new PR if this can't be updated.

Uyadav207 commented 3 years ago

Screenshot from 2021-03-26 23-58-19

@pranshuchittora, pls help me how can I resolve this??

Uyadav207 commented 3 years ago

@pranshuchittora, please have a look...

Screenshot from 2021-03-27 00-14-24

jugshaurya commented 3 years ago

@pranshuchittora, please have a look...

Screenshot from 2021-03-27 00-14-24

  • after running npm prepare... i.e injecting props... The error is still there... Might be the Case the directory is not found.
  • current import STATEMENT Screenshot from 2021-03-27 00-16-00

@Uyadav207 , problem is solvable when you run npm i, npm i is running injectProps.js, which is adding Props folder to the appropritate folder. So wait for the https://github.com/react-native-elements/playground/pull/97 to be merged and then run npm i once more to get folder into the codebase/workspace

Uyadav207 commented 3 years ago

@pranshuchittora, please have a look... Screenshot from 2021-03-27 00-14-24

  • after running npm prepare... i.e injecting props... The error is still there... Might be the Case the directory is not found.
  • current import STATEMENT Screenshot from 2021-03-27 00-16-00

@Uyadav207 , problem is solvable when you run npm i, npm i is running injectProps.js, which is adding Props folder to the appropritate folder. So wait for the #97 to be merged and then run npm i once more to get folder into the codebase/workspace

Resolved.. The folder was injected ... but in wrong sub folder