search

react-native-elements / react-native-elements-app

Demo app for React Native Elements (w/ React Native Web)
https://reactnativeelements.com/
1.29k stars 417 forks source link

Fix Typescript Errors #145

Open flyingcircle opened 3 years ago

flyingcircle commented 3 years ago

I have recently converted all of the code to typescript. It should still compile just fine, but it would be nice to have the demo app be a good check on the correctness of the developer experience of using the library.

There are a lot of hanging typescript errors. This would be to go through and fix them so that tsc passes cleanly.

khushal87 commented 3 years ago

I would like to take up this, and fix the issues.

khushal87 commented 3 years ago

@flyingcircle Can you assign me this issue?

khushal87 commented 3 years ago

The rest of the issues are coming up from the package react-native-elements therefore this can be closed. @flyingcircle

flyingcircle commented 3 years ago

I'd prefer this stay open. If there's an issue showing up here, then we need a ticket written in RNE for it to be solved.

khushal87 commented 3 years ago

The ticket is already there. I am working on the potential fixes of the same in the package. Reference - https://github.com/react-native-elements/react-native-elements/issues/2870 @flyingcircle

flyingcircle commented 3 years ago

Great. Let's keep the ticket open here so that when it's done, we can validate that it's fixed here before closing.

khushal87 commented 3 years ago

Yes. @flyingcircle

khushal87 commented 3 years ago

I will try to handle the strict mode issues too soon. @flyingcircle Can I do so?