search

react-native-elements / react-native-elements-app

Demo app for React Native Elements (w/ React Native Web)
https://reactnativeelements.com/
1.29k stars 417 forks source link

Addition of Dialogs Page #182

Closed Dhananjayan-PN closed 3 years ago

Dhananjayan-PN commented 3 years ago

Summary

Upon implementation of the new Dialog component, introduced in this Issue and implemented in this PR, I have incorporated this into the demo app with a new page dedicated to dialogs and their different types. Here's a quick look at what it looks like:

flyingcircle commented 3 years ago

That looks great. It looks like you tried to update the yarn.lock file, so now this is out of date.

Dhananjayan-PN commented 3 years ago

I just pulled the current yarn.lock file in the repository and pushed it to my fork. Ready to review!

flyingcircle commented 3 years ago

Same here, the lock file is off now.

Dhananjayan-PN commented 3 years ago

what would you suggest would be the best way to resolve this?

Dhananjayan-PN commented 3 years ago

Okay, I figured it out. I just fetched it from upstream. There are no more changes to yarn.lock in the PR

Dhananjayan-PN commented 3 years ago

Hey @flyingcircle! Kindly merge this PR along with https://github.com/react-native-elements/react-native-elements/pull/2911 Thanks!