search

react-native-elements / react-native-elements-universe

MIT License
9 stars 6 forks source link

Proposal for Data Table #3

Open HariAcidReign opened 3 years ago

HariAcidReign commented 3 years ago

Is your feature request related to a problem? Please Describe.

So an RNE user requested for a DataTable component within the library, similar to the one in RN Paper, but with an "out of the box" support for sorting the elements. I believe having a native table component within RNE would be a fantastic addition.

Link to the conversation thread: https://reactnativetraining.slack.com/archives/C4SGR92P8/p1618320417150600

Describe the solution you'd like

I feel the best solution would be to add react-native-table-component (https://www.npmjs.com/package/react-native-table-component) as a dependency and implement sorting into a PR. This way I can pick up an existing component and build on it. Open to other methods of implementation as well.

Describe alternatives you've considered

Additional context

If this is selected, I'll be making the component here, and creating the UI demo in RNE-App 🙌🏻

andyasberry commented 3 years ago

We are building an app for technicians in the field, and need to display good amounts of data in a tabular format for them, providing them with the ability to sort and filter.

RNE is super popular and lightweight, and having this available out-of-the-box with some nice styling would be awesome for us!

Hope to see this in RNE soon!

flyingcircle commented 3 years ago

The RN Paper solution seems interesting. I'm not sure how I feel about taking on another 3rd party library dependency like the one you have. It makes the RNE library dependent on updates from them.

HariAcidReign commented 3 years ago

@flyingcircle understood. So, which of the alternatives that I have proposed would you prefer that I proceed on?

Nevertheless, the npm package seems to be old (last updates 2Y ago) so using it as a dependency or forking it into RNE won't cause problems down the road. It would also help me from reinventing the wheel. I can focus on the styling and sorting features challenges from the get-go.

What do you think?

HariAcidReign commented 3 years ago

I'm interested in bringing this component to RNE. If not in this repo, I can add this component to react-native-elements-universe. As this will be my first shot at adding a new component, I am open to any and all alternatives and guidance that I can get

HariAcidReign commented 3 years ago

@pranshuchittora I want to tackle this one first. Can I proceed with this feature? Should I use some other method to make the component, or is this one perfect?

hsavit1 commented 3 years ago

it would be great to have this, as react-native-web becomes more popular, the need for a data-table component grows