onFinishRating does not fire on Rating component from @rneui/themed

123epsilon commented 1 year ago

Is there an existing issue for this?

[x] I have searched the existing issues

Explain what you did

Attempted to use the swipe rating component and extract the rating value as given by onFinishRating, and found that the event did not fire by using console.log() to debug.

Expected behavior

The event should fire and return the value of the user selected rating.

Describe the bug

The onFinishRating event does not fire when a user finishes selecting a rating using the rating component. I would expect this to fire when the user lifts their finger.

Steps To Reproduce

I was using this and verified this issue in my own app, but reproduced this issue using the snack linked in the official RNEUI docs here: https://reactnativeelements.com/docs/components/rating

Following that link, running the code sample, and viewing the logs show that the event does not fire and print the console.log() statement as expected.

Screenshots

No response

Your Environment

`npx @rneui/envinfo`

``` React Native Elements Env Info ## Global Dependencies: No related dependency found ## Local Dependencies: - @rneui/base : ^4.0.0-rc.7 - @rneui/themed : ^4.0.0-rc.7 - expo : ~47.0.9 - react : 18.1.0 - react-native : 0.70.5 ```

enzocussuol commented 12 months ago

Same problem here... only solution i found was to use the Rating component from react-native-ratings.

https://www.npmjs.com/package/react-native-ratings

123epsilon commented 10 months ago

Same problem here... only solution i found was to use the Rating component from react-native-ratings.

https://www.npmjs.com/package/react-native-ratings

Thanks! This solved the problem for me, weird - this makes this library basically unusable :/

chaiwattsw commented 8 months ago

still have this issue. props is not working

react-native-elements / react-native-elements