react-native-google-signin / google-signin

Google Sign-in for your React Native applications
https://react-native-google-signin.github.io/
MIT License
3.12k stars 876 forks source link

App name gets changed when asking permissions to login in iOS #1195

Closed WossomGonzo closed 10 months ago

WossomGonzo commented 10 months ago

Steps to Reproduce

Just created an app which name has a dot or a space in it, like in my case: "C. Futbol"

Expected Behavior

The popup's title asking the user to confirm to login via Google should say: "C. Futbol" Wants to Use "google.com" to Sign in This allows the app and website to share information about you

Actual Behavior

The popup's title should say: "CFutbol" Wants to Use "google.com" to Sign in This allows the app and website to share information about you

Environment

require 'json' podfile_properties = JSON.parse(File.read(File.join(dir, 'Podfile.properties.json'))) rescue {}

ENV['RCT_NEW_ARCH_ENABLED'] = podfile_properties['newArchEnabled'] == 'true' ? '1' : '0' ENV['EX_DEV_CLIENT_NETWORK_INSPECTOR'] = '1' if podfile_properties['EX_DEV_CLIENT_NETWORK_INSPECTOR'] == 'true'

platform :ios, podfile_properties['ios.deploymentTarget'] || '13.0' install! 'cocoapods', :deterministic_uuids => false

prepare_react_native_project!

If you are using a react-native-flipper your iOS build will fail when NO_FLIPPER=1 is set.

because react-native-flipper depends on (FlipperKit,...), which will be excluded. To fix this,

you can also exclude react-native-flipper in react-native.config.js

#

```js

module.exports = {

dependencies: {

...(process.env.NO_FLIPPER ? { 'react-native-flipper': { platforms: { ios: null } } } : {}),

}

}

```

flipper_config = FlipperConfiguration.disabled if ENV['NO_FLIPPER'] == '1' then

Explicitly disabled through environment variables

flipper_config = FlipperConfiguration.disabled elsif podfile_properties.key?('ios.flipper') then

Configure Flipper in Podfile.properties.json

if podfile_properties['ios.flipper'] == 'true' then flipper_config = FlipperConfiguration.enabled(["Debug", "Release"]) elsif podfile_properties['ios.flipper'] != 'false' then flipper_config = FlipperConfiguration.enabled(["Debug", "Release"], { 'Flipper' => podfile_properties['ios.flipper'] }) end end

target 'CFtbol' do use_expo_modules! config = use_native_modules!

use_frameworks! :linkage => podfile_properties['ios.useFrameworks'].to_sym if podfile_properties['ios.useFrameworks'] use_frameworks! :linkage => ENV['USE_FRAMEWORKS'].to_sym if ENV['USE_FRAMEWORKS']

Flags change depending on the env values.

flags = get_default_flags()

use_react_native!( :path => config[:reactNativePath], :hermes_enabled => podfile_properties['expo.jsEngine'] == nil || podfile_properties['expo.jsEngine'] == 'hermes', :fabric_enabled => flags[:fabric_enabled],

An absolute path to your application root.

:app_path => "#{Pod::Config.instance.installation_root}/..",
# Note that if you have use_frameworks! enabled, Flipper will not work if enabled
:flipper_configuration => flipper_config

)

post_install do |installer| react_native_post_install( installer, config[:reactNativePath],

Set mac_catalyst_enabled to true in order to apply patches

  # necessary for Mac Catalyst builds
  :mac_catalyst_enabled => false
)
__apply_Xcode_12_5_M1_post_install_workaround(installer)

# This is necessary for Xcode 14, because it signs resource bundles by default
# when building for devices.
installer.target_installation_results.pod_target_installation_results
  .each do |pod_name, target_installation_result|
  target_installation_result.resource_bundle_targets.each do |resource_bundle_target|
    resource_bundle_target.build_configurations.each do |config|
      config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
    end
  end
end

end

post_integrate do |installer| begin expo_patch_react_imports!(installer) rescue => e Pod::UI.warn e end end end


-  cocoapods version: 1.12.1
vonovak commented 10 months ago

Hello and thanks for reporting, You want to change the "product name" option under -> build settings in Xcode. Then the dialog will display your app name correctly Thank you 🙂