search

react-native-google-signin / google-signin

Google Sign-in for your React Native applications
https://react-native-google-signin.github.io/
MIT License
3.12k stars 876 forks source link

Misleading Readme #1197

Closed elementace closed 6 months ago

elementace commented 10 months ago

Your readme alludes that the below configuration is necessary for expo installation.

"android": {
    "googleServicesFile": "./google-services.json"
 },
 "ios": {
    "googleServicesFile": "./GoogleService-Info.plist"
 }

As a noob it took me many hours of debugging/googling to understand that the above is for Firebase configuration and not necessary for basic builds. Can we please split this into a different section that clearly outlines for use with Firebase and save other noobs some time. thank you :)

vonovak commented 10 months ago

Hello and thanks for reporting, I believe this part of the readme was contributed when expo support was added. I did not author that, and missed to point out in review that firebase is not required. The docs can be clearer in this area.

Since you have first-hand experience with the problem, would you like to contribute a PR that improves the docs?

Thank you 🙂

vonovak commented 6 months ago

This is now resolved in the latest docs. Thank you 🙂