react-native-google-signin / google-signin

Google Sign-in for your React Native applications
https://react-native-google-signin.github.io/
MIT License
3.12k stars 876 forks source link

Google sign in button almost unpressable. #1200

Closed jbienia closed 7 months ago

jbienia commented 10 months ago

Steps to Reproduce

Expected Behavior

Should be able to easily press the button anywhere(on the button) and see the onPress callback fire

Actual Behavior

There seems to be a very small part of the button that registers the tap.

Environment

vonovak commented 10 months ago

Hello and thanks for reporting, do you have code to reproduce this with? I cannot repro. Thank you 🙂

jbienia commented 9 months ago

@vonovak Do you just want to see how I've implemented it in the file?

vonovak commented 9 months ago

@jbienia I'm looking for this: https://stackoverflow.com/help/minimal-reproducible-example

thank you

jbienia commented 9 months ago

Sure. There's a not a lot to it. The only way the button taps properly for me is doing what you see below. The onPress is on the TouchableWithoutFeedback instead. In a simulator it works fine with a mouse click, but on my physical device it behaves differently with the touch. When you tried to reproduce did you use a physical(Android) device?

import { GoogleSignin, GoogleSigninButton } from '@react-native-google-signin/google-signin';

<TouchableWithoutFeedback style={styles.button} onPress={() => onGoogleButtonPress()}> <GoogleSigninButton style={{ marginTop: 20, width: 230, height: 48 }} size={GoogleSigninButton.Size.Wide} color={GoogleSigninButton.Color.Light} /> </TouchableWithoutFeedback>

vonovak commented 9 months ago

hello @jbienia

The only way the button taps properly for me is doing what you see below

I'm rather interested in the issue reproduction, that is, what code do you use that has the problem of not being able to press the button? What is the code that does not work?

thank you

jbienia commented 9 months ago

The onPress does not fire when I tap the button on a physical device. I have to tap it multiple times and in very specific spot to get the function in the onPress prop to execute. Did you try it to reproduce with with a physical device?

<GoogleSigninButton size={GoogleSigninButton.Size.Wide} color={GoogleSigninButton.Color.Dark} onPress={() => console.log("I AM PRESSED")} disabled={this.state.isSigninInProgress} />;

GKyomen commented 8 months ago

Same here

vonovak commented 7 months ago

I cannot repro this, so I'm going to close the issue. Please open a new issue if the problem persists. Thank you 🙂