docs: update readme and guides.

[thorwebdev]

Fixes #1197

• Update the README and guides with what worked for me just now.

[github-actions[bot]]

:tada: This issue has been resolved in version 10.1.1 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket:

[GiantPineappleStatue]

https://react-native-google-signin.github.io/docs/setting-up/expo

I think the new doc site's readme is still showing the old readme? It still includes adding config file to android.

[vonovak]

@GiantPineappleStatue can you please explain it more? What is the problem and what do you expect to see? thanks!

[GiantPineappleStatue]

@GiantPineappleStatue can you please explain it more? What is the problem and what do you expect to see? thanks!

Hey, thanks for replying.

new doc site gave this as part of setting up an expo project { "expo": { "android": { "googleServicesFile": "./google-services.json" }, "ios": { "googleServicesFile": "./GoogleService-Info.plist" }, "plugins": ["@react-native-google-signin/google-signin"] } }

but according to https://github.com/react-native-google-signin/google-signin/pull/1207/commits/10ab37877d938b2df4c3739a82e03f4fcf09959a the updated installation instruction should be

{ "expo": { "plugins": ["@react-native-google-signin/google-signin"] } }

could you confirm?

[vonovak]

@GiantPineappleStatue no, I cannot confirm at this moment because I didn't look into the details of what the config plugin does and if it works without the config files.

When you look at that commit more closely, it just moves the googleServicesFile configuration around, but does not remove it. So I'd still stick with using it and it's what we're documenting in https://react-native-google-signin.github.io/docs/setting-up/get-config-file

I'm going to look into it again in a few weeks, I have now spent a lot already on new features and the new docs website. But if you want to dig into it yourself, you absolutely can and I'll be curious to hear what you found :)

thank you

[GiantPineappleStatue]

@GiantPineappleStatue no, I cannot confirm at this moment because I didn't look into the details of what the config plugin does and if it works without the config files.

When you look at that commit more closely, it just moves the googleServicesFile configuration around, but does not remove it. So I'd still stick with using it and it's what we're documenting in https://react-native-google-signin.github.io/docs/setting-up/get-config-file

I'm going to look into it again in a few weeks, I have now spent a lot already on new features and the new docs website. But if you want to dig into it yourself, you absolutely can and I'll be curious to hear what you found :)

thank you

Hi, thanks again for taking the time. I think I was just confused because the googleServiceFiled are(as far as i can tell anyway) only for Firebase setup with Expo but was given as general installation instruction.

[vonovak]

Hello @GiantPineappleStatue I have updated the docs and they should now be much clearer. I even published a new config plugin for non-firebase use with Expo.

Hope this helps.

[GiantPineappleStatue]

@vonovak Thank you very much for all your work!