search

react-native-google-signin / google-signin

Google Sign-in for your React Native applications
https://react-native-google-signin.github.io/
MIT License
3.12k stars 877 forks source link

Update ExpoAdapterGoogleSignIn.podspec #1225

Closed aniolpages closed 6 months ago

aniolpages commented 6 months ago

Raise iOS target to 13.4 (https://reactnative.dev/blog/2023/12/06/0.73-debugging-improvements-stable-symlinks)

vonovak commented 6 months ago

hello and thanks for the PR!

Why do you need this?

Thank you :)

aniolpages commented 6 months ago

Hello! AFAIK this is necessary when using the latest version of React Native, and also for the upcoming Expo SDK 50. The iOS target on React Native has been set to 13.4

https://reactnative.dev/blog/2023/12/06/0.73-debugging-improvements-stable-symlinks#other-breaking-changes https://expo.dev/changelog/2023/12-12-sdk-50-beta#notable-breaking-changes

Thanks!

vonovak commented 6 months ago

I'm not a cocoa pods expert but I don't think the change is needed.

Expo sdk 50 is already available so the current version of the code can be tested.

Are you getting build errors without the proposed change?

Thank you

aniolpages commented 6 months ago

This is the error message I get when trying to build the project with Expo SDK 50:

/Users/aniolpages/.../node_modules/@react-native-google-signin/google-signin/expo/ios/ExpoAdapterGoogleSignIn/GoogleSignInAppDelegate.swift:2:8 Compiling for iOS 13.0, but module 'ExpoModulesCore' has a minimum deployment target of iOS 13.4: /Users/aniolpages/Library/Developer/Xcode/DerivedData/...-ebnglklyowllpzegjzhzjmzvnaib/Index.noindex/Build/Products/Debug-iphoneos/ExpoModulesCore/ExpoModulesCore.swiftmodule/arm64-apple-ios.swiftmodule

aniolpages commented 6 months ago

Tried it and now I get this:

/Users/aniolpages/.../node_modules/@react-native-google-signin/google-signin/expo/ios/ExpoAdapterGoogleSignIn/GoogleSignInAppDelegate.swift:2:8 Compiling for iOS 4.3, but module 'ExpoModulesCore' has a minimum deployment target of iOS 13.4: /Users/aniolpages/Library/Developer/Xcode/DerivedData/...-ebnglklyowllpzegjzhzjmzvnaib/Index.noindex/Build/Products/Debug-iphoneos/ExpoModulesCore/ExpoModulesCore.swiftmodule/arm64-apple-ios.swiftmodule

/Users/aniolpages/.../node_modules/@react-native-google-signin/google-signin/expo/ios/ExpoAdapterGoogleSignIn/GoogleSignInAppDelegate.swift:6:67 'URL' is only available in iOS 8.0 or newer

vonovak commented 6 months ago

Thank you for your PR! :)

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 11.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: