search

react-native-google-signin / google-signin

Google Sign-in for your React Native applications
https://react-native-google-signin.github.io/
MIT License
3.12k stars 877 forks source link

OneTap fails on web when 'sign-in prompts' are disabled #1242

Closed hbriese closed 4 months ago

hbriese commented 5 months ago

Repository with code that reproduces the issue

  1. Disable Google's "Google Account sign-in prompts" setting
  2. Open your example app
  3. Press the onetap sign in with google button on web
  4. Look in dev console for error GET https://accounts.google.com/gsi/status?client_id=... net::ERR_BLOCKED_BY_CLIENT

Expected Behavior

Sign in prompt shows

Actual Behavior

GoogleOneTapSignIn.signIn() throws Error: One-tap sign in not displayed: suppressed_by_user

Environment

Additional info

This occurs not just when the given setting is disabled, but also when the 1Password extension is installed (see thread) 1Password recommends implementing Google's new personalized sign in with google button which works when the setting is disabled

vonovak commented 4 months ago

Hello and thanks for reporting, it seems that in my effort to unify the exposed apis across all platforms, I have made some sacrifices that create problems. I'm going to look into this soon.

Thank you 🙂

vonovak commented 4 months ago

@hbriese can you please try v14 of the sponsor module and let me know if that helps. There are some breaking changes, and update instructions in https://github.com/react-native-google-signin/google-signin-next/releases/tag/v14.0.0

hope this helps! :)

vonovak commented 4 months ago

hello @hbriese have you had a chance to check the v14 behavior?

Thank you

hbriese commented 4 months ago

hello @hbriese have you had a chance to check the v14 behavior?

Thank you

Unfortunately I had to do away with the one-tap flow on web as I require the access token (implicit flow) which it doesn't provide. One-tap is ‎🔥 on Android atleast