search

react-native-google-signin / google-signin

Google Sign-in for your React Native applications
https://react-native-google-signin.github.io/
MIT License
3.12k stars 877 forks source link

Upgrade GoogleSignIn-iOS to 7.1.0 in order to support Apple Privacy Manifest #1265

Closed adorum closed 1 month ago

adorum commented 3 months ago

Please upgrade GoogleSignIn-iOS to 7.1.0 in order to support Apple Privacy Manifest.

hatn-lumin commented 3 months ago

^ same issue

vonovak commented 3 months ago

Hello and thanks for asking, To have an easy fix, we need to wait for a new release of GoogleSignIn-iOS SDK. I'll update this when the fix is ready.

Anyone who wants to track the status, please use the "subscribe" button on the right.

Thank you 🙂

vonovak commented 3 months ago

@adorum

re https://github.com/google/GoogleSignIn-iOS/issues/341#issuecomment-2034482388

yes, it is, but this is not https://github.com/openid/AppAuth-iOS/commit/eee20d36310e37a26dde368b23c681a7616ec69b

vonovak commented 2 months ago

Btw if anyone wants to use 7.1.0 of the google sign in pod, use https://github.com/react-native-google-signin/google-signin/releases/tag/v11.0.0

However, you'll need to work around #1263

mobileteo commented 2 months ago

Any ETA about the release with 7.1.0?

sjabeen-guru commented 2 months ago

@vonovak https://github.com/openid/AppAuth-iOS/commit/eee20d36310e37a26dde368b23c681a7616ec69b this is also done so any ETA regarding privacy manifest?

guru-5 commented 2 months ago

@vonovak can u pls provide the new update with support of Apple Privacy Manifest

vonovak commented 2 months ago

Hello and thanks for asking, I see most of you who commented have joined Github recently. I would like to - politely but at the same time strongly - ask you to not add comments to issues, if your comments don't add any value.

I said clearly at the top, that if you're interested to receive updates, you can hit "subscribe" on the right, and when there is an update, you'd receive it. Instead, through commenting and mentioning me repeatedly, you're sending useless notifications to me and everybody else subscribed. People who are interested in actual updates are getting spammed by your comments. So, please, please, don't do that.

Thank you 🙂

Now, for the update: v14.3.0 here which is available to sponsors, contains the Google sign in SDK v7.1 with the privacy manifest. For those who are anxious to get the latest version, you can do that by sponsoring me - you will also get access to the "One-tap Google sign in" which Google started pushing forward. The "original google sign in" is becoming deprecated.

I will also make this change available in the public repo before end of the month. Thank you :)

Baudouin-Renie commented 2 months ago

Hi @vonovak, could you please tell us when exactly this change will be available in the public repo? Starting tomorrow, we'll need it to release our app in the AppStore. Thanks a lot!

mateusdegobi commented 1 month ago

I will also make this change available in the public repo before end of the month.

I know you asked not to add unnecessary comments, however, we are eagerly awaiting this update. I hope I don't bother you with that.

vonovak commented 1 month ago

Hi, Apologies, I left for vacation and didn't get to do everything I wanted. I also disabled notifications so I took a little longer to notice. As a workaround for the issue, you should be able to downgrade to v11.0.0 or v10.1.1 to resolve the problem.

Hope this helps! 🙂

github-actions[bot] commented 1 month ago

:tada: This issue has been resolved in version 12.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: