Mock not working in 12.1.0

gcottrell1 commented 1 month ago

After updating to 12.1.0, the mock is causing an error when running my tests

Cannot find module '../src/types' from 'node_modules/@react-native-google-signin/google-signin/jest/build/setup.js'

Here is what the module looks like when installed

inside jest/build/setup.ts

Repository with code that reproduces the issue

You must provide a minimal and easy-to-run reproduction of your issue - how to create a minimal reproduction?. We're a small team of maintainers and do not have time to try reproduce bugs ourselves.
Please try to reproduce the bugs on the provided example app. Either provide a link to the repo that reproduces the bug or provide your version of the index.js file that reproduces the issue and that we can easily use.
Explain the steps we need to take to reproduce the issue.
Include a gif if you think it may help.
If you're asking for help, please make it easy for us to help you!

Expected Behavior

mock works

Actual Behavior

mock doesn't work

Environment

Please provide

react-native version 0.73.8
@react-native-google-signin/google-signin version 12.1.0
your Podfile, output of running pod install and cocoapods version (if applicable)
version of Android, gradle, android plugin for gradle, play-services-auth and version of the Google Play Services app on your phone (if applicable)
version of iOS (if applicable)

devartwa commented 1 month ago

I'm having the same issue, but it seems so simple to fix. I've tried to put "../../src/types" and it worked.

gcottrell1 commented 1 month ago

@devartwa yes its simple enough to patch a fix but thats just a band-aid. The distribution should be fixed properly as any other future imports would face the same issue

devartwa commented 1 month ago

@devartwa yes its simple enough to patch a fix but thats just a band-aid. The distribution should be fixed properly as any other future imports would face the same issue

Sure, I agree! I've cloned the app and tried to run tsc inside the jest folder and it worked like a charm, something happened whey they built and released this version, for sure.

devartwa commented 1 month ago

@vonovak could you please have a look on this?

vonovak commented 1 month ago

Hello, I'll take a look today

devartwa commented 1 month ago

Hello, I'll take a look today

thank you so much!

github-actions[bot] commented 1 month ago

:tada: This issue has been resolved in version 12.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

devartwa commented 1 month ago

@vonovak I know it's a dumb question, but have you tested before the release? I've updated the library and got the same error.

library version:

vonovak commented 1 month ago

Hello, apologies! The correct location of the mock is @react-native-google-signin/google-signin/jest/build/jest/setup.js

I will update the release notes with this breaking change

devartwa commented 1 month ago

Hello, apologies! The correct location of the mock is @react-native-google-signin/google-signin/jest/build/jest/setup.js

I will update the release notes with this breaking change

thank you so much again!

react-native-google-signin / google-signin