react-native-masked-view / masked-view

React Native Masked View Library
MIT License
962 stars 121 forks source link

Support new React Native new architecture (TurboModules/Fabric) #162

Closed tom-sherman closed 5 months ago

tom-sherman commented 2 years ago

See https://reactnative.dev/docs/new-architecture-library-intro

https://reactnative.dev/blog/2022/06/16/resources-migrating-your-react-native-library-to-the-new-architecture

unfernandito commented 2 years ago

Hi @tom-sherman

I'm working in this support https://github.com/react-native-masked-view/masked-view/pull/164

unfernandito commented 2 years ago

@tom-sherman currently, fabric for android is full working, you can try my fork if you want.

iOS Fabric is barely supported in my fork, not crash but right now I'm stuck with this issue when you try to use the lib:

image

I guess the issue is in the UIManager and how it works under fabric architecture but I'm pretty lost, I'll continue searching for a solution

hansdesmedt commented 1 year ago

I started a new discussion about this issue

https://github.com/reactwg/react-native-new-architecture/discussions/80

hansdesmedt commented 1 year ago

hey @unfernandito I created a PR on your PR, can you check and merge both into this lib? Thx!

issues fixed:

https://github.com/unfernandito/masked-view/pull/3

hansdesmedt commented 1 year ago

or I can create a PR with the changes of @unfernandito and mine directly into this repo?

unfernandito commented 1 year ago

Hey, yes i Will check your pr

aleksey-mukho commented 1 year ago

Any updates?