search

react-native-masked-view / masked-view

React Native Masked View Library
MIT License
976 stars 125 forks source link

Use deprecate-react-native-prop-types #166

Closed irmakcosarsahna closed 2 years ago

irmakcosarsahna commented 2 years ago

Platforms affected All

What does this PR do? RN 0.68 has deprecated and will eventually remove ViewPropTypes (see post). This adds the deprecated-react-native-prop-types package and uses that instead.

What testing has been done on this change? Local testing, to ensure the deprecation warning has been removed.

Naturalclar commented 2 years ago

@irmakcosarsahna thanks for the PR I think it's better to remove the deprecated props altogether rather than replace the type with deprecated-react-native-prop-types, since using the deprecated types also will remove backwards compatability with older react-native versions

Naturalclar commented 2 years ago

Will close this PR in favor of #169