react-native-masked-view / masked-view

React Native Masked View Library
MIT License
960 stars 120 forks source link

feat(all): add support RN <0.71 when add namespace #197

Closed ngocle2497 closed 11 months ago

ngocle2497 commented 1 year ago

Overview

In prev-PR, i remove package from AndroidManifest.xml file, it drop support for RN <0.71. Now, I check ANDROID_GRADLE_PLUGIN_VERSION to use namespace and remove package in AndroidManifest.xml file

Test Plan

ngocle2497 commented 11 months ago

i think we need to update like this

  if (supportsNamespace()) {
    namespace "com.org.reactnative.maskedview"

    sourceSets {
      main {
        manifest.srcFile "src/main/AndroidManifestNew.xml"
      }
    }
  }