react-native-menu / menu

UIMenu Component for React Native

MIT License

1.01k stars 62 forks source link

Fix iOS building on CI #806

Closed svbutko closed 6 months ago

svbutko commented 6 months ago

Overview

Removed unwanted lock files
Updated react-native-test-app to fix issues with Embed Manifest failing to find app.json

In order to work in CI, next changes needs to be added to ci.yml for Build example app:


run: cd example/ios && xcodebuild -workspace MenuExample.xcworkspace -scheme MenuExample -destination "platform=iOS Simulator,id=F882DE2D-825C-4D22-A66D-682FCF5FCCF8" CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NO -skip-testing:ReactTestAppTests/ReactNativePerformanceTests

svbutko commented 6 months ago

@Naturalclar the git hook is also has to be changed in order to work as I mentioned in description, I unfortunately can't change it, only authorized author can adjust it