search

react-native-picker / picker

Picker is a cross-platform UI component for selecting an item from a list of options.
MIT License
1.49k stars 280 forks source link

fix: add ref support for Web #376

Closed LucioChavezFuentes closed 2 years ago

LucioChavezFuentes commented 2 years ago

A few changes on forwardedRef allows anyone to pass a React refon Web version and get a ref of <select> tag that renders Picker. I am currently using a forked version with these changes in order to get focus( ) method of <select> tag and avoid dirty code.

Let me know guys what do you think. I am fully available to make any changes neccesary.

rushatgabhane commented 2 years ago

@Naturalclar gentle bump to review this when you get the time, thanks so much!

Fixes issue https://github.com/react-native-picker/picker/issues/375

Naturalclar commented 2 years ago

@LucioChavezFuentes CI seems to be failing could you do me a favor and run the linter on lines you edited?

LucioChavezFuentes commented 2 years ago

@Naturalclar I fixed the lint errors. You can review it again.

LucioChavezFuentes commented 2 years ago

And thank you for your time to review.

Naturalclar commented 2 years ago

:tada: This PR is included in version 2.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

LucioChavezFuentes commented 2 years ago

Thank you @Naturalclar, I really appreciate your time on review.