search

react-native-picker / picker

Picker is a cross-platform UI component for selecting an item from a list of options.
MIT License
1.49k stars 280 forks source link

fix: Workaround XAML bug with ComboBox and dark theme #380

Closed christophpurrer closed 2 years ago

christophpurrer commented 2 years ago

Currently picker does not support darkMode (at least in our XamlIsland based app). This issues seems to be identical to: https://github.com/microsoft/microsoft-ui-xaml/issues/2331. The solution is based of https://github.com/microsoft/react-native-windows/pull/8777/files . Before:

1

After

2
christophpurrer commented 2 years ago

@Naturalclar > Does this change look good to you?

Naturalclar commented 2 years ago

:tada: This PR is included in version 2.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

nitishagrawal-yara commented 1 year ago

This issue is not fixed for Android. The same issue I am getting in android.