search

react-native-picker / picker

Picker is a cross-platform UI component for selecting an item from a list of options.
MIT License
1.47k stars 277 forks source link

fix: adding deprecated-react-native-prop-types to support react-native 0.69 and above #448

Closed vzhovnitsky closed 1 year ago

vzhovnitsky commented 1 year ago

The correct fix here is to switch to deprecated-react-native-prop-types or a type system like Typescript. Back in 2018 facebook/react-native started removing PropTypes from React Native. Last year, in 0.68 they introduced a deprecation warning which notified users that the change is coming, and in 0.69 we removed the PropTypes entirely.

Naturalclar commented 1 year ago

@vzhovnitsky Thank you for the PR! However, I believe the flow type ViewProps is still being used in react-native here

What got deleted was ViewPropType that used prop-types which is slightly different.

vzhovnitsky commented 1 year ago

@vzhovnitsky Thank you for the PR! However, I believe the flow type ViewProps is still being used in react-native here

What got deleted was ViewPropType that used prop-types which is slightly different.

Oh, I might have misread, my bad, closing PR then?

Naturalclar commented 1 year ago

@vzhovnitsky no problem! thanks for taking your time trying to improve the package. Closing the PR