search

react-native-picker / picker

Picker is a cross-platform UI component for selecting an item from a list of options.
MIT License
1.45k stars 273 forks source link

Delete deprecated receiveCommand for INT #568

Closed arushikesarwani94 closed 1 month ago

arushikesarwani94 commented 1 month ago

receiveCommand(@NonNull ReactPicker root, int commandId, @androidx.annotation.Nullable ReadableArray args) for INT was deprecated 5 years ago in favour of receiveCommand(@NonNull ReactPicker root, String commandId, @androidx.annotation.Nullable ReadableArray args)

This is needed to get rid of dispatchCommand INT variant here : https://github.com/facebook/react-native/blob/044aadbaf6830b21aab821804dc5a7989010022e/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java#L591-L595

The usages in @react-native-picker/picker are all dependent on String variant

arushikesarwani94 commented 1 month ago

cc: @Naturalclar for review

Naturalclar commented 4 weeks ago

:tada: This PR is included in version 2.7.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: