search

react-native-push-notification / ios

React Native Push Notification API for iOS.
MIT License
748 stars 285 forks source link

PushNotificationiOS crashes app for iOS 14 #195

Open chahinaghrim opened 4 years ago

chahinaghrim commented 4 years ago

Current Live App uses React-Native : 0.62

We currently use the PushNotificationiOS service for changing the badge count of our app. Currently, whenever a user that has an iPhone with iOS 14 gets a notification, the app gets following error and crashes the app:

img_3167cef17973-1

For all users below iOS 14, the service works well. Even when upgrading react-native to 0.63 and upgrading PushNotificationIOS to 1.6.0 , it keeps crashing the app.

Need help asap. Thanks in advance!

ghasemikasra39 commented 4 years ago

I am facing the same behaviour on react native 0.63.3, ios 14.0.1, PushNotificationIOS 1.6.0. Any solution?

hasfoug commented 4 years ago

Same for me, after upgrading to IOS 14

alon7 commented 4 years ago

Same for me, I had to patch the package to remove the completionHandler as recommended above

fatihyildizhan commented 3 years ago

@ghasemikasra39 upgrade to 1.7.1. Remote notification is working for me with rn 0.63.3and iOS 14.0.1

douglasdc commented 3 years ago

Same for me, I had to patch the package to remove the completionHandler as recommended above

Patching to remove the call of completionHandler, the remote notification still working?

raldred commented 3 years ago

Is this similar to https://github.com/react-native-push-notification-ios/push-notification-ios/issues/163 Can it be patched in the same way? https://github.com/react-native-push-notification-ios/push-notification-ios/pull/234

Naturalclar commented 3 years ago

I've released 1.7.5-beta.0 with potential fix for this. I wasn't able to reproduce the crash with the original package, so could someone verify that this change fixes the crash?

douglasdc commented 3 years ago

I've released 1.7.5-beta.0 with potential fix for this. I wasn't able to reproduce the crash with the original package, so could someone verify that this change fixes the crash?

Hei, I tested with that beta and it keeps happening. I have used that package as dependency of push-notification to trigger a local notification.

The android package request the following use notification.finish(PushNotificationIOS.FetchResult.NoData); and that is what is causing the trouble, removing it, or commenting the handler solves that issue.

The error:

Screen Shot 2020-11-23 at 10 26 50
Lkubok commented 3 years ago

upgrade version 1.8.0 fixes this problem. tested on iOS 14.2, 14.3 and react-native-0.64.rc1

saadalvi92 commented 3 years ago

React-native push notification ios Causes app crash for me in ios 14 and pushNotification Ios 1.8.0 . The App Crashed when the Notification Registers in AppDelicate.m