search

react-native-push-notification / ios

React Native Push Notification API for iOS.
MIT License
734 stars 282 forks source link

Support repeatIntervals of minute, hour, day, week, month, and year in addNotificationRequest() #308

Closed jamesxabregas closed 2 years ago

jamesxabregas commented 2 years ago

This pull request adds logic to enable addNotificationRequest() to have repeating logic simmilar to that provided by scheduleLocalNotification() which is deprecated. addNotificationRequest() now supports a repeatInterval parameter with values minute, hour, day, week, month, year. This pull request also fixes a bug with addNotificationRequest() that meant that the notification request didn't repeat daily as documented even if the repeats parameter was set to true (it was configured in a way that meant it would only fire once).

mklb commented 2 years ago

+1 🎉 I would love to see this merged. This would be very helpful!

Naturalclar commented 2 years ago

@jamesxabregas thank you so much for the suggestion! along with review for #268 I've added your suggestions you made in #268 and published in v1.10.0 :tada: Closing this PR