search

react-native-voice / voice

:microphone: React Native Voice Recognition library for iOS and Android (Online and Offline Support)
MIT License
1.81k stars 488 forks source link

fix: new NativeEventEmitter() was called with a non-null argument console warning #460

Open reynaldichernando opened 1 year ago

reynaldichernando commented 1 year ago

Add addListener and removeListeners method to stop console warning about:

WARN new NativeEventEmitter() was called with a non-null argument without the required addListener method.
WARN new NativeEventEmitter() was called with a non-null argument without the required removeListeners method.

Issue #455

reference

rzfzr commented 10 months ago

Is this a breaking change or just a warning? I'm trying to figure out why voice is not working.

Edit for reference: not a breaking change that I could see, voice still worked despite the warning

angusryer commented 8 months ago

NOTE: Anyone can review this PR, but in order for it to be merged automatically, we need the author or a contributor to review it.

cetorres commented 2 months ago

Please merge this changes. Thank you.

abasiri commented 2 months ago

Verified that this fixes the issue for me. Would be good if it gets merged. cc: @wenkesj @safaiyeh Thank you.

AshwinTayson commented 1 month ago

Can someone merge this? Or is this not maintained anymore?