search

react-native-webrtc / react-native-callkeep

iOS CallKit framework and Android ConnectionService for React Native
ISC License
897 stars 436 forks source link

Support video option on Android #193

Open namnm opened 4 years ago

namnm commented 4 years ago

Bug report

Description

Look like ConnectionService support video call, can we add support for it in this RN module?

danjenkins commented 4 years ago

I've got partial support in a branch of you're interested

On Mon, 4 May 2020, 02:49 Nam Nguyen, notifications@github.com wrote:

Bug report

-

I've checked the example https://github.com/react-native-webrtc/react-native-callkeep/tree/master/example to reproduce the issue.

Reproduced on:

Android

Description

Look like ConnectionService support video call, can we add support for it in this RN module?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/react-native-webrtc/react-native-callkeep/issues/193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB3LLPIJBAQ3Y2TDB4LMM3RPYNJNANCNFSM4MYMKKHQ .

namnm commented 4 years ago

@danjenkins Which branch you mean?

danjenkins commented 4 years ago

It's on the nimbleape GitHub org - currently on my phone will find it once I'm at my desk for you

namnm commented 4 years ago

Thanks. I think this one: https://github.com/nimbleape/react-native-callkeep-1/tree/allow-non-numbers-and-android-video

I'll take a look. Although video option is not a critical requirement for us now, but soon or later we will need it.

sboily commented 4 years ago

@danjenkins how can we help you to finish this branch? We are currently working to integrate video calls in our application and we will work to integrate video on callkeep, but it will be probably better to work together to don't reinvented the wheel ;-) CC @manuquentin

danjenkins commented 4 years ago

@sboily I could move the branch over to this repo for starters?

For me, I think the main part thats missing is the VideoProvider class ? I think....

https://developer.android.com/reference/android/telecom/Connection.VideoProvider

But more than happy to move that branch over, or I can give you guys access into the nimble ape repo.

sboily commented 4 years ago

@danjenkins yes i haven't any objections to do that. If it help people to contribute it, no worry.

danjenkins commented 4 years ago

@sboily the code is now in branch react-native-webrtc/react-native-callkeep#allow-non-numbers-and-android-video , however it currently does multiple things... (it was a branch for a client that I'm not done with) - firstly - disables hold support (we need to be able to enable/disable this thorugh config options), enables support for the sip scheme, and does enough work for video support to work but needs extra work!

sboily commented 4 years ago

@danjenkins can you make this branch as a PR to discuss directly in the PR. And can you give us more information about the extra work needs you think?

sboily commented 4 years ago

iOS video support #181

alebagran commented 4 years ago

Hi, is there any news on video call implementation?

luxiliu commented 4 years ago

Hi @danjenkins , apart from VideoProvider, using own ui to display call also needs to be considered.

danjenkins commented 4 years ago

@luxiliu there's already a feature request for it in the issues tracker. If you want to build the code and contribute it, the collaborators will get to it when any of us get time. Building real time Comms apps on native is incredibly complex and we all have day jobs. None of us build things and keep them private, they immediately go public. Have the common decency to read through the issues and see whats already been asked for and stop wasting people's time. If you had you'd have seen that someone has already built most of this functionality bit hasn't got the time to integrate it back into this repo right now - if you need this functionality then you could use the form that's been listed in an issue for over 6 months.

Think before commenting. Please.

danjenkins commented 4 years ago

Hi, is there any news on video call implementation?

Nope... Otherwise there would have been a comment or a PR closing this......

Seriously, please start considering collaborators have lives and jobs before commenting asking for updates when if there was..... They would have already been posted here.

luxiliu commented 4 years ago

@danjenkins , I think you misunderstood what I meant. I was not pushing you for a pr or a fix. I was just saying it is also an option, which need to consider just incase you're developing it.

Think before replying. Please.

danjenkins commented 4 years ago

@luxiliu my point would be that if this gets done before that work (99% probably this way around) then that work would be done as part of that other PR.

luxiliu commented 4 years ago

@danjenkins unfortunately, i didn't get ur point.

meliodev commented 4 years ago

@danjenkins Thank you so much guys for your efforts and the great support you provide for the react native community. My respects !

meliodev commented 4 years ago

Hey guys again, please I need a small help. I am using agora.io, and I am trying to build a video call functionality with ringing tone on android. I used the example in the branch 'allow-non-numbers-and-android-video'. So when I call the function displayIncomingCall, even after I set the parameter 'hasVideo' to true, I still get the UI of a voice call after the call is answered. Can somebody please give some tips to make the Video call UI displayed on call answer.

luxiliu commented 4 years ago

Hey guys again, please I need a small help. I am using agora.io, and I am trying to build a video call functionality with ringing tone on android. I used the example in the branch 'allow-non-numbers-and-android-video'. So when I call the function displayIncomingCall, even after I set the parameter 'hasVideo' to true, I still get the UI of a voice call after the call is answered. Can somebody please give some tips to make the Video call UI displayed on call answer.

Either you need a VideoProvider or you need to implement your own UI for the video call.

meliodev commented 4 years ago

@luxiliu I would like to use my own UI, but the issue is that I couldn't figure out how to configure the button 'answer call' to navigate to my own UI for video call. Please, do you have a solution for this ?

luxiliu commented 4 years ago

@luxiliu I would like to use my own UI, but the issue is that I couldn't figure out how to configure the button 'answer call' to navigate to my own UI for video call. Please, do you have a solution for this ?

Some of us are working on this PR https://github.com/react-native-webrtc/react-native-callkeep/pull/237. There's a newly added event RNCallKeepPerformShowIncomingCallAction. When receiving this event, you could show your own ui

meliodev commented 4 years ago

@luxiliu I would like to use my own UI, but the issue is that I couldn't figure out how to configure the button 'answer call' to navigate to my own UI for video call. Please, do you have a solution for this ?

Some of us are working on this PR #237. There's a newly added event RNCallKeepPerformShowIncomingCallAction. When receiving this event, you could show your own ui

Perfect !

namnm commented 4 years ago

@luxiliu Just take a look as your PR and it's promising. There's something I want to ask, that if you tried the backToForeground method when app is killed?

I tested it like: if user click on answer button then call that method. And look like it works when app in background. When app is killed and receive the notification, Im able to show the incoming call, but not able to open the app when click on the answer button.