search

react-native-webrtc / react-native-callkeep

iOS CallKit framework and Android ConnectionService for React Native
ISC License
888 stars 432 forks source link

Package androidx.localbroadcastmanager.content does not exist #594

Open alexanderoskin opened 2 years ago

alexanderoskin commented 2 years ago

Bug report

Description

Package androidx.localbroadcastmanager.content does not exist error in VoiceConnection.java:27.

Steps to Reproduce

Install latest Callkeep and try to build project for Android with the latest React Native.

Versions

- Callkeep: 4.3.3
- React Native: 0.69.1

Logs

/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/VoiceConnection.java:27: error: package androidx.localbroadcastmanager.content does not exist
import androidx.localbroadcastmanager.content.LocalBroadcastManager;
                                             ^
ohheyitskartik commented 2 years ago

Hey, i have been facing a similar issue and i found out that google has split the v4 library into multiple packages :

Note: Prior to Support Library revision 24.2.0, there was a single v4 support library. That library was divided into multiple modules to improve efficiency. For backwards compatibility, if you list support-v4 in your Gradle script, your app will include all of the v4 modules. However, to reduce app size, we recommend that you just list the specific modules your app needs.

hence we need to add explicitly mention androidx.localbroadcastmanager:localbroadcastmanager:1.1.0 dependency.

i wanted to create PR for the same but dont have push rights, if someone can help me with that, it will be great.

Till then i have created a fork with fix here - https://github.com/ohheyitskartik/react-native-callkeep-with-broadcast-manager

sboily commented 2 years ago

Hello @ohheyitskartik, everyone have the right to open a PR. I don't understand why you said that. Do you have a message for this issue? Sylvain

ohheyitskartik commented 2 years ago

@sboily, my bad i just cloned the repo & didn't fork it hence i was not able to select my branch for a PR, i have just raised one #596

NguyenVanVietPoLy commented 2 years ago

@alexanderoskin that work, open node_modules/react-native-callkeep/android/build.graldew add :
implementation "androidx.localbroadcastmanager:localbroadcastmanager:1.1.0" run npx patch-package react-native-callkeep

w4ugit commented 1 year ago

how can I fix this error so that I don't have to modify the plugin files every time?

whoiswentz commented 1 year ago

When this bug will be fixed?

chiragpurohit71085 commented 1 year ago

Facing the same issue

I have to update build.gradle at following path.

/node_modules/react-native-callkeep/android/build.gradle

I have attached gradle file as build.txt due to github security.

image build.txt

SoftermiiMK commented 1 year ago

"react-native": "0.70.0", "react-native-callkeep": "^4.3.3",

same issue

*Update

Fix merged to master but not released yet

Sheharyar566 commented 1 year ago

waiting for the fix to be released

pierguinzani commented 1 year ago

@manuquentin, can you update the package on https://www.npmjs.com/package/react-native-callkeep??

pantomath91 commented 1 year ago

package need to be released new version, although it should be automated

ashirkhan94 commented 1 year ago

Same issue for me

GittyAjay commented 1 year ago

any update on this issue ?

mstadius commented 1 year ago

Until a new version is released you can change in your package.json file

"react-native-callkeep": "4.3.3",

to

"react-native-callkeep": "git+https://github.com/react-native-webrtc/react-native-callkeep#4b1fa98a685f6502d151875138b7c81baf1ec680",

to get the fix right away.

ashirkhan94 commented 1 year ago

Any update

alaaamady commented 1 year ago

is this released yet? and if it's not is there any workarounds to use this fix?

Baloo1 commented 1 year ago

I think this is fixed with 4.3.4 released in commit 054ece7