search

react-native-webrtc / react-native-callkit

#deprecated iOS 10 new CallKit framework for React Native
ISC License
122 stars 67 forks source link

CallKit uppercasing call uuid #23

Open bsiddiqui opened 6 years ago

bsiddiqui commented 6 years ago

If I call RNCallKit.endCall('ae708c43-f567-4bcf-8940-fb7013a8aa30'), the end call callback will get data with the uuid uppercased:

{ callUUID: 'AE708C43-F567-4BCF-8940-FB7013A8AA30' }

Is that expected?

brunsy commented 6 years ago

It's caused by the use of NSUUID everywhere... For now I ended up converting back to lowercase in the event listeners.

@ianlin would you accept a PR to accept mixed case but always return lowercase UUID's?

ianlin commented 6 years ago

Hi @bsiddiqui @brunsy, thanks for pointing this out. Yeah definitely welcome any PR :)