search

react-native-webrtc / react-native-callkit

#deprecated iOS 10 new CallKit framework for React Native
ISC License
122 stars 67 forks source link

localizedCallerName added to displayIncomingCall #33

Closed aarkalyk closed 6 years ago

aarkalyk commented 6 years ago

Added localizedCallerName for displaying a callerName, so that handle can be used for storing caller id/number. Please, review the PR. Thanks!

aarkalyk commented 6 years ago

My bad😬 Just fixed it!

ianlin commented 6 years ago

Thanks! react-native-callkit 1.3.2 released.

sujameslin commented 6 years ago

@aarkalyk Can you please add localizedCallerName support to startCall method too?

aarkalyk commented 6 years ago

@sujameslin Sure 👌

sujameslin commented 6 years ago

@aarkalyk Did you manage to add localizedCallerName to startCall method?

aarkalyk commented 6 years ago

@sujameslin turns out there's no localizedCallerName in CXStartCallAction class. There's contactIdentifier instead, which seems like to be used for same purposes. Here's what apple's docs say about it:

The identifier is displayed in the native call UI, and is typically the name of the call recipient.