search

react-native-webrtc / react-native-callkit

#deprecated iOS 10 new CallKit framework for React Native
ISC License
122 stars 67 forks source link

Android Support? #7

Open neel132-zz opened 7 years ago

neel132-zz commented 7 years ago

Will it be available on Android?

jmesquita commented 7 years ago

CallKit is a technology that is exclusive to iOS. I've not yet fully investigated how to emulate the same thing on Android but it seems like the not so well documented approach is using ConnectionServices class to create a wrapper. Either way, I don't think having that wrapper on this module is not appropriate but I'm not the project owner, so I don't know.

ianlin commented 7 years ago

I've noticed ConnectionServices from Android API 23 just then... It looks interesting and just like CallKit on Android. Will get some time looking at it or any PR is welcome.

ccaapton commented 6 years ago

Cordova integrated both Callkit for iOS and ConnectionService for Android here: https://www.npmjs.com/package/cordova-call

Hope react-native could implement it soon.

pewh commented 6 years ago

Hey @ianlin, I'm newbie here and curious about ConnectionService. You mention that it's from Android API 23. If my project use useTargetVersion=25 and minTargetVersion=16, can I still use ConnectionService?

basitsattar commented 6 years ago

Any update?

spiffylogic commented 6 years ago

Am I the only one who finds it very ironic to stumble upon a library for a cross-platform development framework that only works for iOS? Disappointing.

angvp commented 5 years ago

@spiffylogic Patches welcome!

manuquentin commented 5 years ago

Hello, If you want a support for Android and iOS, we've forked this repository and added it in : https://github.com/wazo-pbx/react-native-callkeep

zxcpoiu commented 5 years ago

@manuquentin

Awesome! Thanks for your decent works.

Would you mind to join as collaborator and merge back? ( or your recommended persons ) It would be nice for community to maintain a single code base if roadmap is fairly the same.

We can indicating the contributions in the readme, or even moved this repo to a neutral owner, like, an organization.

Sounds good?

sboily commented 5 years ago

Hello @zxcpoiu,

There is multiple reasons we don't do that.

1/ We check the activity on this repo and it looks like there is nothing happened for a long time. No PR merged, no new code. I understand sometime people have another priority.

2/ The name is oriented to be as callkit for iOS and not for android. That's why we changed the name on the fork.

3/ We develop an application for business and we need to have reactivities on this library and we don't want to depends on someone we don't know his priority and his roadmap.

But i'm clearly open to discuss about neutral organisation for open source telecom components. Maybe we can also think about react-native-webrtc, push notification etc ... We are open source telecom developers so i understand this discussion. I think there is other people who are very interested for this initiative.

Let me know, i'm available to discuss when you want. Sylvain

danjenkins commented 5 years ago

I completely agree with @sboily (I must say I am a contributor to callkeep but not employed by wazo) - this repo hasn't been active as of late; whether that could change if we could add more contributors to the repo is up for debate but there are PRs open for months with no comment on them. To me, this project looked like it was essentially dead from the outside - so much so I've been maintaining a couple of forks for clients of mine and wondering what to do about contributing changes back as well as what happens when I wanted to do android work. The Wazo team were in a similar position and so forked it and renamed the project - completely agree with this - callkit is an iOS thing and you can't really go down the route of renaming this project because people rely on it so it makes sense to have another project which handles both anyway.

I'm in the same industry as @sboily - and completely trust that he's open to moving things into an open source telecoms org or something - I don't believe thats necessary - as people contribute good PRs to callkeep, they could be added to the wazo repo. I need a library that keeps up to date, is responsive to PRs etc, rn-callkit wasn't that recently. If anything I'd say that there shouldn't be any more development on rn-callkit, it should be marked as archived and a link should be made over to callkeep where all future development should happen. If thats going to happen we could then add any contributors to rn-callkit over to callkeep

zxcpoiu commented 5 years ago

Hey, @danjenkins @sboily , thanks for your reply.

I am in the same industry as well, but more personally. :handshake:

First thing first, please don't get me wrong, I'm not trying to convince to keep ownership. ( I'm not @ianlin btw. ) Maybe it's a little bit exaggerated, but believe it or not, I could't sleep well because seeing these repos dying but don't have time to keep it going.

People comes and goes, it's normal to see the original repo dead and lives on a forked repo. To me, except it's a bit sad and ugly, there are new comers does not aware of it and keep open issues / PRs in the original repo even it was clearly indicating / redirecting to another one. Especially the original repo stays at the front of search results. It's normal but not that healthy to open source.

I've talked to @ianlin and @oney, and we all have the same thoughts. If someone are willing to take off these repos, we are all willing to transfer ownership to them as well, as long as it's better for open source community.

Actually, @saghul pre-created an organization named: react-native-webrtc and we are planning to move react-native-webrtc into it.

This makes me thinking that, why not we create an org like: react-native-telephony or react-native-telecom or react-native-voip and move these repos into one, if react-native-webrtc is included, as least we'll have:

This org can gather people in the similar industry together, we'll have more eyes, more organized, more discussions, more ideas.....

Sounds exciting and lovely, no?

There must be noted that an outside repo no matter whether it is a personal one or under an organization, more or less, will block a little bit roadmap of a business, since it may need some discussions when it comes to breaking changes or dirty workaround.

I totally understand what you concern about from a business perspective, it makes scene. And if it is better to keep it under wazo to you after discussion, @ianlin are willing to transfer ownership to you if needed.

Thanks for your time and contributions :+1: :smile:

zxcpoiu commented 5 years ago

About the callkit naming, it's not that important so I split it into here.

I still think callkit is a better name because lots people does not aware android that has this functionality like iOS as well. People usually asked callkit-like feature on android. Didn't mention the name ConnectionService is confusing enough. They search callkit and found this repo, then, oh ya, it supports android as well! intuitive.

react-native-callkeep on the other hand, is more like some kind of call queue / music on hold plugin at a glance.

Not for debate, just some thoughts. Actually, I don't care that much what is the name in the end. :smiley:

p.s. when renaming a repo, all URL, clones and forks are redirected to the new URL automatically by github with love.

https://help.github.com/articles/renaming-a-repository/

sboily commented 5 years ago

Hey, @danjenkins @sboily , thanks for your reply. ... This makes me thinking that, why not we create an org like: react-native-telephony or react-native-telecom or react-native-voip and move these repos into one, if react-native-webrtc is included, as least we'll have:

  • react-native-webrtc
  • react-native-callkit or react-native-callkeep
  • react-native-voip-push-notification
  • react-native-incall-manager
  • react-native-carrier-info ( well, if it still useful )
  • ...etc

This org can gather people in the similar industry together, we'll have more eyes, more organized, more discussions, more ideas.....

Sounds exciting and lovely, no?

Good idea, it will be nice to have an org like react-native-voip or something like this with all stuff around voip and telecommunication with react.

saghul commented 5 years ago

@sboily I'll be happy to add you to https://github.com/react-native-webrtc if we agree on the name :-)

sboily commented 5 years ago

@saghul Thank you for your proposal. Maybe we can open a discussion in another public place to have an open discussion around this organisation? I like this idea to have all webrtc/voip/telecom in a same neutral organisation. Do we need to talk about the governance, repo access etc...? What's the mission? :)

saghul commented 5 years ago

@sboily Sure, let's talk about it! How about here? https://react-native-webrtc.discourse.group It could also server as a discussion forum for all the things in this org.

neo125874 commented 5 years ago

@saghul @sboily @danjenkins @zxcpoiu Thanks you guys for the Libs, I have used them to build the instant-messenger like Line/WhatsApp; If you construct the org. for share/discussion, I have lots of feedback(code, issue, problem, etc.) maybe could be useful for you, haha

saghul commented 5 years ago

@neo125874 Feel free to drop by https://react-native-webrtc.discourse.group/

zxcpoiu commented 5 years ago

Hi @sboily @manuquentin

Since we are on the new home now, just wanted to let you guys know, react-native-callkit is under your charges now :+1: ( governance / main lead and the main maintainer to this repo )

So feel free to do what you want to do. Either merging the two repos, or deprecation / redirection ...etc.

sboily commented 5 years ago

Hello @zxcpoiu, ok thank you.

We'll talk with @manuquentin about the futur of this repo. But it will be nice to have feedback from people about continuing to develop in this repo. Probably it will be better for all to have one repo to support iOS and android with the same library, but community feedback is welcome, we don't know exactly if people prefer to have a specific library for iOS or not and i think this is the only subject to keep it.

Thank you for your confidence!