search

react-native-webrtc / react-native-callkit

#deprecated iOS 10 new CallKit framework for React Native
ISC License
122 stars 67 forks source link

EndCall fix #9

Open eugenehp opened 7 years ago

eugenehp commented 7 years ago

https://github.com/ianlin/react-native-callkit/issues/3

as explained here http://stackoverflow.com/questions/38793722/error-while-requesting-a-transaction-with-cxendcallaction

ianlin commented 7 years ago

Hey @eugenehp thanks for this.

In my case using either action.UUID or action.callUUID works as expected. From the log output the value of action.UUID is different from that of action.callUUID while action.callUUID is identical to the uuid I pass when calling startCall react method.

This is a bit weird.. Can you please share some information about your environment like the iOS version and how you use this module?

Thanks!

joshuaalpuerto commented 7 years ago

Hi @ianlin , this PR works for this issue. #3 Hope this one will be merge soon.

sujameslin commented 6 years ago

@eugenehp Can you please resolve conflict?

aarkalyk commented 6 years ago

According to the apple doc UUID in reportCallWithUUID:(NSUUID *)UUID is

The unique identifier of the call.

Whereas, UUID of CXAction object is

The unique identifier for the action.

and callUUID of CXCallAction object is

The unique identifier for the call associated with the action.

I believe we should stick to the current version where we pass startCallAction.callUUID.

@eugenehp @ianlin @sujameslin Guys, can we close this one?

zek commented 5 years ago

That needs to be merged. I have also same issue #3 . It is not closed and after a while I am getting "CALL FAILED" message.