react-native-webrtc / react-native-incall-manager

Handling media-routes/sensors/events during a audio/video chat on React Native
ISC License
555 stars 192 forks source link

Can't build the library in android for buildToolsVersion = "28.0.3" #110

Open pouraghajanOldAcc opened 5 years ago

pouraghajanOldAcc commented 5 years ago

Hi and thanks for this great library I want to build my RN app with the latest android API level (which is 28 right now) but when I try to build and run the project on my test device it fails because of this library is usig API level 23.0.1 and consequently there would be API level mismatch. Is there any way to use this library with API levels higher than 23.0.1 at all?

My development environment info:: react-native-cli: 2.0.1 react-native: 0.59.5 JDK 1.8.0_151

xxx\node_modules\react-native-incall-manager\android\src\main\java\com\zxcpoiu\incallmanager\InCallManagerModule.java:37: error: cannot find symbol import android.support.v4.app.ActivityCompat; ^ symbol: class ActivityCompat location: package android.support.v4.app xxx\node_modules\react-native-incall-manager\android\src\main\java\com\zxcpoiu\incallmanager\InCallManagerModule.java:38: error: cannot find symbol import android.support.v4.content.ContextCompat; ^ symbol: class ContextCompat location: package android.support.v4.content xxx\node_modules\react-native-incall-manager\android\src\main\java\com\zxcpoiu\incallmanager\InCallManagerModule.java:1433: error: cannot find symbol if (ContextCompat.checkSelfPermission(reactContext, targetPermission) == PackageManager.PERMISSION_GRANTED) { ^ symbol: variable ContextCompat location: class InCallManagerModule xxx\node_modules\react-native-incall-manager\android\src\main\java\com\zxcpoiu\incallmanager\InCallManagerModule.java:1508: error: cannot find symbol ActivityCompat.requestPermissions(currentActivity, new String[] {targetPermission}, requestPermissionCode); ^ symbol: variable ActivityCompat location: class InCallManagerModule

zxcpoiu commented 5 years ago

You can overrides versions like in https://github.com/facebook/react-native/blob/master/template/android/build.gradle#L4-L10

Didn't you?