search

react-native-webrtc / react-native-incall-manager

Handling media-routes/sensors/events during a audio/video chat on React Native
ISC License
555 stars 192 forks source link

SetSepakerPhone android bug fix #201

Closed Azamatjon closed 1 year ago

Azamatjon commented 2 years ago

SetSepakerPhone android bug fix Related with https://github.com/react-native-webrtc/react-native-incall-manager/issues/164#issuecomment-1235548452 and tested with android device

zxcpoiu commented 1 year ago

Thanks for pointing out the discussion.

I see your point. we have start() function and set the audio mode to MODE_IN_COMMUNICATION, but somehow for some use case, uses the setSpeakerPhoneOn without start, the the audio mode does not change to the MODE_IN_COMMUNICATION

This module is focus on talking, so we have defaultAudioMode = AudioManager.MODE_IN_COMMUNICATION already. So I change the way and the execution place to use the defaultAudioMode

For future folks, if you did not use start() first but use other functions and encounter some thing like echo, remember to set the desired audioMode yourself based on your audio case.