search

react-native-webrtc / react-native-voip-push-notification

React Native VoIP Push Notification - Currently iOS only
ISC License
213 stars 83 forks source link

Implemented expo plugin #111

Open jexodusmercado opened 4 months ago

jexodusmercado commented 4 months ago

Added expo plugin to modify AppDelegate with development builds

Note: I haven't included any test to check the generated AppDelegate. Currently works with my setup. Let me know if you have encountered any issues

ruslanjabari commented 4 months ago

God bless.

ruslanjabari commented 4 months ago

@jexodusmercado

issue: when updating the callerName via RN, the underlying callerName still retains "Connecting..."

This happens because of this line: NSString *callerName = [NSString stringWithFormat:@"%@ (Connecting...)", payload.dictionaryPayload[@"callerName"]];"

wilkinsonj commented 3 months ago

Hey guys, LOVE this, its badly needed.

Suggestion: the 'video' property (YES or NO) should be based on the payload (like UUID, Handle etc). Otherwise there's no way to initiate a video call (which is important as it opens the app straight away once the call is accepted, and also appears in the call description)

And on that note, I think all properties should be configurable from payload, and have defaults (if not provided in the payload). I spent a lot of time working out why the app was crashing due to hard coded expectation of variables in the payload.

For example, handle could be 'Unknown caller' if no handle property is in the data dictionary. Video could default to YES.

frozencap commented 1 month ago

yes please

AlanGreyjoy commented 1 month ago

@ianlin Can we get this on a track for merging soon?

jexodusmercado commented 3 weeks ago

@zxcpoiu can you check and merge this if applicable? Thanks!

southkeys commented 1 week ago

what's the hold up?