react-native-webrtc / react-native-webrtc-web-shim

Web Shim for React Native WebRTC
MIT License
18 stars 11 forks source link

Props are not handled as expected #13

Open gavrilikhin-d opened 4 months ago

gavrilikhin-d commented 4 months ago

Describe the bug If you use mirror prop, then you would get:

Warning: Received `true` for a non-boolean attribute `mirror`.

If you want to write it to the DOM, pass a string instead: mirror="true" or mirror={value.toString()}.
    at video
    at Video
    at RTCView (webpack://mobile/./node_modules/react-native-webrtc-web-shim/src/RTCView.web.js?:1:1135)

Versions (please complete the following information):

gavrilikhin-d commented 4 months ago

Same goes for objectFit

Warning: React does not recognize the `objectFit` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `objectfit` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at video
    at Video
    at RTCView (webpack://mobile/./node_modules/react-native-webrtc-web-shim/src/RTCView.web.js?:1:1135)
gavrilikhin-d commented 4 months ago

And zOrder :)

agent.ts:1 Warning: React does not recognize the `zOrder` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `zorder` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at video
    at Video
    at RTCView (webpack://mobile/./node_modules/react-native-webrtc-web-shim/src/RTCView.web.js?:1:1135)
8BallBomBom commented 4 months ago

Planned for the next release, can't confirm exact functionality at this point 🤔 But the idea is to have everything function the same between platforms.

DavidGOrtega commented 4 weeks ago

👋 When is the next release?

8BallBomBom commented 4 weeks ago

Currently focused on a few projects including new arch support for the main rn webrtc repo. But this is planned to be worked on within the coming weeks in-between that.