react-native-webview / react-native-webview

React Native Cross-Platform WebView
https://github.com/react-native-community/discussions-and-proposals/pull/3
MIT License
6.31k stars 2.96k forks source link

fix: Remove log statement that breaks react-native-community autolinking config #3367

Closed brentvatne closed 3 months ago

brentvatne commented 3 months ago

When running a build in a project without a react-native.config.js with the log in metro.config.js catch block:

FAILURE: Build failed with an exception.

* Where:
Script '/Users/brent/code/with-webview/node_modules/@react-native-community/cli-platform-android/native_modules.gradle' line: 442

* What went wrong:
A problem occurred evaluating script.
> Calling `[node, /Users/brent/code/with-webview/node_modules/@react-native-community/cli/build/bin.js, config]` finished with an exception. Error message: groovy.json.JsonException: Unable to determine the current character, it is not a string, number, array, or object

  The current character read is 'H' with an int value of 72
  Unable to determine the current character, it is not a string, number, array, or object
  line number 1
  index number 0
  Hello? Error: Failed to find `react-native.config.js`
  ^. Output: Hello? Error: Failed to find `react-native.config.js`
      at configureProjects (/Users/brent/code/with-webview/node_modules/react-native-test-app/scripts/configure-projects.js:169:11)

As an aside - I don't know much about react-native-test-app, but I'm somewhat surprised it has anything to do with the config that is being run anywhere outside of the context of when you are building the app.

brentvatne commented 3 months ago

merged quickly because it's a hotfix

react-native-community-bot commented 3 months ago

:tada: This PR is included in version 13.8.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: