search

react-native-webview / react-native-webview

React Native Cross-Platform WebView
https://github.com/react-native-community/discussions-and-proposals/pull/3
MIT License
6.3k stars 2.95k forks source link

Fix crash when opening 4xx pages with no description. #3416

Closed bimusiek closed 1 week ago

bimusiek commented 1 month ago

Hey, at https://freeyourmusic.com we have a weird case, where user is redirected to a page with 404 error that crashes on iOS. After further investigation, we found that this is because of description=NULL as seen on screenshot: CleanShot 2024-04-25 at 15 24 05@2x

This PR fixes this issue and possibly https://github.com/react-native-webview/react-native-webview/issues/3412

DorianMazur commented 2 weeks ago

@Titozzz @jamonholmgren Can you check this? This is important PR and I think should be merged after applying change suggested in my comment.

bimusiek commented 2 weeks ago

@chiaramooney @Titozzz I would love to have this merged. We still use simple patch now, but this is quite common crash for any non 200 page that does not return description. Also, as reported by someone else, this is also crashing for Cloudflare protected pages in case of 403 there.

Seemed like quite nice bug fix, but it is more than a month now without any response or comment? :)

TheAlmightyBob commented 1 week ago

@bimusiek It's saying "This branch is out-of-date with the base branch" but not giving me any option to rebase it (don't think I've seen GitHub do that before...?). Are you able to update this branch?

bimusiek commented 1 week ago

@TheAlmightyBob Done

react-native-community-bot commented 1 week ago

:tada: This PR is included in version 13.10.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: