search

react-navigation / hooks

React hooks for convenient react-navigation use
https://reactnavigation.org
MIT License
576 stars 36 forks source link

useFocusEffect / useIsFocused #43

Closed slorber closed 5 years ago

slorber commented 5 years ago

@satya164 does it feel ok?

Didn't use the use-subscription package for now, didn't know about it but will take a look.

Also didn't invest in tests because there's not yet any test infra, not much time, and this project is probably only temporary until people use the v5. But those hooks will be used in my app right now so I'm pretty confident to see if something breaks.

Will add some doc too.

slorber commented 5 years ago

Hi @satya164 I've made some changes and added some doc

slorber commented 5 years ago

Thanks :) seems ready to merge now