search

react-navigation / react-navigation

Routing and navigation for your React Native apps
https://reactnavigation.org
23.3k stars 4.97k forks source link

feat: introduce missing props from native-stack v5 (v6) #11957

Closed tboba closed 3 weeks ago

tboba commented 3 weeks ago

Motivation

Follow-up for PR #11803 that introduced props from native-stack v5 to v7. Here, I'm migrating missing props also to native-stack v6. Take a look in original PR for more information about this change.

Test plan

You can test these props by checking how they affect screens after adjusting them in Native Stack example. Remember about setting presentation to formSheet while using sheetX props.

Some of the examples I've already prepared:

Using GestureResponseDistance on NewsFeed This will enable changing the area of the gesture with a rectangle starting from the ~middle of the screen down to bottom. `NativeStack.tsx:139` ```tsx ```
Using sheet props on NewsFeed This will change the NewsFeed screen to the form sheet with rounded corners and maximum height to the middle. `NativeStack.tsx:139` ```tsx ```
tboba commented 3 weeks ago

Chosen wrong branch.

github-actions[bot] commented 3 weeks ago

Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro.

netlify[bot] commented 3 weeks ago

Deploy Preview for react-navigation-example ready!

Name Link
Latest commit d89d4a1ae079add0e7e4cf0fc723ab8b458cfb8f
Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/66278ada79530100085ec41e
Deploy Preview https://deploy-preview-11957--react-navigation-example.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.