IOS fullscreenmodal not switching to dark/light mode when changing appearance - Githubissues

react-navigation / react-navigation

Routing and navigation for your React Native apps

https://reactnavigation.org

23.3k stars 4.97k forks source link

IOS fullscreenmodal not switching to dark/light mode when changing appearance #11964

Open the-devbear opened 3 weeks ago

the-devbear commented 3 weeks ago

Current behavior

The fullscreenmodal doesn't switch appearance when appearance is switch on phone.

https://github.com/react-navigation/react-navigation/assets/104125178/6bf39ab0-bf54-42e6-9851-27342de74aa7

Expected behavior

The fullscreenmodal should switch appearances when toggling dark/light mode just like the "normal" modal.

Reproduction

https://snack.expo.dev/@dev_bear/github.com-the-devbear-react-navigation-mre-fullscreenmodal

Platform

[ ] Android
[X] iOS
[ ] Web
[ ] Windows
[ ] MacOS

Packages

[ ] @react-navigation/bottom-tabs
[ ] @react-navigation/drawer
[ ] @react-navigation/material-top-tabs
[ ] @react-navigation/stack
[X] @react-navigation/native-stack
[ ] react-native-tab-view

Environment

[x] I've removed the packages that I don't use

package	version
@react-navigation/native	^6.1.17
@react-navigation/native-stack	^6.9.26
react-native-safe-area-context	4.8.2
react-native-screens	~3.29.0
react-native	0.73.6
expo	~50.0.14
node	v20.12.0
npm or yarn	npm

the-devbear commented 3 weeks ago

EDIT: Also just found #11953. Unfortunately I can not switch to containedModal because it has a different behaviour.